Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent setting address(0) as the initialAdmin in AccessManager #4570

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Prevent setting address(0) as the initialAdmin in AccessManager #4570

merged 4 commits into from
Sep 5, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Sep 4, 2023

Similarly to the changes proposed in #4531, we want to prevent construction with address(0) as the admin.

Fixes LIB-1057

PR Checklist

  • Tests

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 68cd06b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested a review from frangio September 4, 2023 13:49
@frangio frangio merged commit bb7ca7d into OpenZeppelin:audit/wip/2a-2b Sep 5, 2023
12 checks passed
@Amxx Amxx deleted the feature/AccessManager/initialAdmin-check branch September 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @frangio